Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus environment variable #2712

Closed
2 of 6 tasks
Tracked by #1689
axiomofjoy opened this issue Mar 28, 2024 · 6 comments · Fixed by #3010
Closed
2 of 6 tasks
Tracked by #1689

Add Prometheus environment variable #2712

axiomofjoy opened this issue Mar 28, 2024 · 6 comments · Fixed by #3010
Assignees
Labels
enhancement New feature or request

Comments

@axiomofjoy
Copy link
Contributor

axiomofjoy commented Mar 28, 2024

  • add environment variable
  • add deprecation warning for command line argument
  • create ticket to remove command line argument in an upcoming sprint
  • change the CMD in the Dockerfile
  • change the CMD in the Arize deployment of Phoenix
  • do a full-text search for --enable-prometheus to make sure we go everything

Originally posted by @mikeldking in #2708 (comment)

@axiomofjoy
Copy link
Contributor Author

@mikeldking Can you clarify the details of this ticket? Do you want to remove the --enable-prometheus command line argument and have an environment variable instead?

@mikeldking
Copy link
Contributor

@mikeldking Can you clarify the details of this ticket? Do you want to remove the --enable-prometheus command line argument and have an environment variable instead?

I think this can be an opt-in feature via env-vars. Not every person that deploys phoenix needs prometheus metrics. To make the integration seamless we should just control it via environment variables rather than a launch command

@axiomofjoy
Copy link
Contributor Author

If I understand correctly, the user should be able to decide whether to run the container with Prometheus at runtime, e.g.,

docker run -it -e "ENABLE_PROMETHEUS=TRUE" arizephoenix/phoenix:latest

@mikeldking
Copy link
Contributor

If I understand correctly, the user should be able to decide whether to run the container with Prometheus at runtime, e.g.,

docker run -it -e "ENABLE_PROMETHEUS=TRUE" arizephoenix/phoenix:latest

Yes, it should be off by default

@mikeldking
Copy link
Contributor

Bumping back in priority.

@axiomofjoy axiomofjoy moved this from 📘 Todo to 👨‍💻 In progress in phoenix Apr 26, 2024
@axiomofjoy
Copy link
Contributor Author

axiomofjoy commented Apr 26, 2024

Fully remove --enable-prometheus command line argument.

@axiomofjoy axiomofjoy moved this from 👨‍💻 In progress to 🔍. Needs Review in phoenix Apr 26, 2024
@axiomofjoy axiomofjoy moved this from 🔍. Needs Review to ✅ Done in phoenix Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants