-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus environment variable #2712
Comments
@mikeldking Can you clarify the details of this ticket? Do you want to remove the |
I think this can be an opt-in feature via env-vars. Not every person that deploys phoenix needs prometheus metrics. To make the integration seamless we should just control it via environment variables rather than a launch command |
If I understand correctly, the user should be able to decide whether to run the container with Prometheus at runtime, e.g.,
|
Yes, it should be off by default |
Bumping back in priority. |
Fully remove |
CMD
in theDockerfile
CMD
in the Arize deployment of Phoenix--enable-prometheus
to make sure we go everythingOriginally posted by @mikeldking in #2708 (comment)
The text was updated successfully, but these errors were encountered: