Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[container] sqlite install #2721

Closed
Tracked by #1689
mikeldking opened this issue Mar 29, 2024 · 6 comments
Closed
Tracked by #1689

[container] sqlite install #2721

mikeldking opened this issue Mar 29, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikeldking
Copy link
Contributor

mikeldking commented Mar 29, 2024

sqllite ships with python but not sure if we can more closely control the version in the container. Worth investigating if we can control the version.

@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Mar 29, 2024
@dosubot dosubot bot added the enhancement New feature or request label Mar 29, 2024
@axiomofjoy
Copy link
Contributor

axiomofjoy commented Mar 29, 2024

I think this issue affects more than just containers. We want to use features from SQLite 3.45, but some older versions of Python ship with older versions of the SQLite database engine.

Python 3.8.17 | packaged by conda-forge | (default, Jun 16 2023, 07:11:32)
[Clang 14.0.6 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sqlite3
>>> sqlite3.sqlite_version
'3.43.0'

@axiomofjoy
Copy link
Contributor

This also affects the current container image, which ships with SQLite v3.40.1. We're going to need to install a custom version of SQLite, either via a third-party library or by packaging SQLite binaries into our own wheels.

@axiomofjoy
Copy link
Contributor

axiomofjoy commented Mar 31, 2024

The best option I've found is apsw.

Alternatively, we can package an sqlite binary into phoenix ourselves if we don't need the apsw python wrapper, but I don't see much advantage to doing that aside from saving a marginal amount of space. The wheels are not too big.

@axiomofjoy
Copy link
Contributor

Looks like it's been a few years since the Conda feedstock had a release.

conda-forge/apsw-feedstock#48

@mikeldking mikeldking moved this from 📘 Todo to 👨‍💻 In progress in phoenix Apr 1, 2024
@mikeldking
Copy link
Contributor Author

Need to determine if JSON binary is worth it
How to get JSON extension installed

@mikeldking mikeldking assigned RogerHYang and unassigned axiomofjoy Apr 3, 2024
@mikeldking mikeldking changed the title [container] sqllite install [container] sqlite install Apr 12, 2024
@mikeldking
Copy link
Contributor Author

too much work

@github-project-automation github-project-automation bot moved this from 👨‍💻 In progress to ✅ Done in phoenix Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants