Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sessions] define a base instrumentor class #2756

Closed
Tracked by #2619
axiomofjoy opened this issue Apr 4, 2024 · 2 comments
Closed
Tracked by #2619

[sessions] define a base instrumentor class #2756

axiomofjoy opened this issue Apr 4, 2024 · 2 comments
Labels

Comments

@axiomofjoy
Copy link
Contributor

axiomofjoy commented Apr 4, 2024

  • should have an explicit span creation hook
  • we need to support multiple priority levels depending on the importance of the semantic convention to make it less likely that important attributes are dropped
@axiomofjoy axiomofjoy mentioned this issue Apr 4, 2024
74 tasks
@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix Apr 4, 2024
@axiomofjoy axiomofjoy changed the title define a base instrumentor class [sessions] define a base instrumentor class Apr 4, 2024
@dosubot dosubot bot added the c/traces label Apr 4, 2024
@axiomofjoy
Copy link
Contributor Author

We need to identify as a team priorities for our existing semantic conventions.

@mikeldking
Copy link
Contributor

Maybe we do a POC and evaluate the downstream impact. Could have issues with coupling our instrumentation to specifics of tracers and context managers that might have side effects.

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Aug 7, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Aug 14, 2024
@github-project-automation github-project-automation bot moved this from 📘 Todo to ✅ Done in phoenix Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants