Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(persistence): get or delete projects using sql #2839

Merged
merged 14 commits into from
Apr 12, 2024
Merged

feat(persistence): get or delete projects using sql #2839

merged 14 commits into from
Apr 12, 2024

Conversation

RogerHYang
Copy link
Contributor

resolves #2838

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 10, 2024
@RogerHYang RogerHYang linked an issue Apr 10, 2024 that may be closed by this pull request
[persistence] get or delete projects using sql #2838
Closed
mikeldking
mikeldking reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let some comments. A tad confused by the indexes....

src/phoenix/core/traces.py Outdated Show resolved Hide resolved
src/phoenix/core/traces.py Outdated Show resolved Hide resolved
src/phoenix/core/traces.py Outdated Show resolved Hide resolved
src/phoenix/server/api/schema.py Show resolved Hide resolved
src/phoenix/core/traces.py Outdated Show resolved Hide resolved
This was referenced Apr 11, 2024
Merged
Closed
axiomofjoy
axiomofjoy approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Are indexes created anonymously able to be migrated?
  • I think you can remove the projects table from one more query.

src/phoenix/server/api/schema.py
Project(
id_attr=project.id,
name=project.name,
project=info.context.traces.get_project(project.name), # type: ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up, it might make sense to key the core projects by ID rather than name.

Copy link
Contributor Author

@RogerHYang RogerHYang Apr 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the (in-memory) core projects will be deleted after migration, so this is moot.

src/phoenix/server/api/schema.py Show resolved Hide resolved
src/phoenix/server/api/schema.py Show resolved Hide resolved
src/phoenix/db/migrations/versions/cf03bd6bae1d_init.py
sa.Integer,
sa.ForeignKey("projects.id", ondelete="CASCADE"),
nullable=False,
index=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these indexes anonymous? Do we need to explicitly name them in order to run migrations on them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're named automatically.

Screenshot 2024-04-12 at 10 29 35 AM

src/phoenix/server/api/types/Project.py Outdated Show resolved Hide resolved
@RogerHYang RogerHYang merged commit 527b9a9 into sql Apr 12, 2024
12 checks passed
@RogerHYang RogerHYang deleted the get-or-delete-projects branch April 12, 2024 17:55
This was referenced Apr 12, 2024
Closed
Merged
Merged
@github-actions github-actions bot mentioned this pull request May 9, 2024
Closed
@mikeldking mikeldking mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking left review comments

@axiomofjoy axiomofjoy axiomofjoy approved these changes

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[persistence] get or delete projects using sql
3 participants
@RogerHYang @mikeldking @axiomofjoy