Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: span filtering by span evaluations #2923

Merged
merged 51 commits into from
Apr 24, 2024
Merged

feat: span filtering by span evaluations #2923

merged 51 commits into from
Apr 24, 2024

Conversation

axiomofjoy
Copy link
Contributor

Adds support for filtering spans by span evaluations.

resolves #2787

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy changed the base branch from main to sql April 19, 2024 00:45
@axiomofjoy axiomofjoy marked this pull request as ready for review April 23, 2024 22:01
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 23, 2024
Copy link
Contributor

@RogerHYang RogerHYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work!

src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
src/phoenix/trace/dsl/filter.py Outdated Show resolved Hide resolved
@axiomofjoy axiomofjoy changed the title feat: span eval filtering by span evaluations feat: span filtering by span evaluations Apr 24, 2024
@axiomofjoy axiomofjoy merged commit 4458ec4 into sql Apr 24, 2024
12 checks passed
@axiomofjoy axiomofjoy deleted the eval-filtering-2787 branch April 24, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[persistence] evaluation filtering on spans and traces
2 participants