Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: span and trace evaluation summaries #3013

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

axiomofjoy
Copy link
Contributor

fixes span and trace evaluation summaries

resolves #3002

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 26, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy changed the base branch from main to sql April 26, 2024 19:38
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 26, 2024
)
labels = [label for label in all_labels if label is not None]
if not evaluations or labels:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains a bug.

)
labels = [label for label in all_labels if label is not None]
if not evaluations or labels:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains a bug.

@axiomofjoy axiomofjoy merged commit 088e6c2 into sql Apr 26, 2024
13 checks passed
@axiomofjoy axiomofjoy deleted the fix-eval-summaries branch April 26, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] missing eval summary metric
2 participants