Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pagination on spans resolver #3046

Merged
merged 78 commits into from
May 8, 2024
Merged

feat: support pagination on spans resolver #3046

merged 78 commits into from
May 8, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented May 1, 2024

  • adds support for id-based pagination to spans resolver
  • removes totalCount from PageInfo type. this is not actually part of the relay spec nor is it is part of strawberry's implementation of PageInfo, and it is no longer free for us to compute.

resolves #3003

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy changed the base branch from main to sql May 1, 2024 03:56
RogerHYang and others added 27 commits May 1, 2024 11:40
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label May 7, 2024
@axiomofjoy axiomofjoy requested a review from RogerHYang May 7, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[persistence] deal with hard cardinality of spans in a time window
3 participants