Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(annotations): annotations UI #3914

Merged
merged 6 commits into from
Jul 23, 2024
Merged

feat(annotations): annotations UI #3914

merged 6 commits into from
Jul 23, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Jul 16, 2024

resolves #3825

This is a minimum working pre-release UI for adding annotations to spans. It does not include edits, only additions and deletions. There are known UX issues that will be addressed as follow-ups.

Screenshot 2024-07-22 at 10 24 08 PM

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 16, 2024
@mikeldking mikeldking marked this pull request as draft July 16, 2024 21:11
@mikeldking mikeldking force-pushed the 3825-annotations-ui branch 2 times, most recently from 211cb1d to 831f595 Compare July 19, 2024 19:59
WIP

WIP

WIP

WIP

add delete annotation functionality

WIP

lint errors

WIP
@mikeldking mikeldking marked this pull request as ready for review July 23, 2024 04:29
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 23, 2024
@mikeldking mikeldking merged commit cd1a48f into main Jul 23, 2024
6 checks passed
@mikeldking mikeldking deleted the 3825-annotations-ui branch July 23, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feedback] [UI] Add the ability to add annotations to a span
2 participants