Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Version mismatch checks #3989

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Conversation

anticorrelator
Copy link
Contributor

resolves #3937

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 24, 2024
@@ -87,6 +87,7 @@
from phoenix.server.grpc_server import GrpcServer
from phoenix.server.telemetry import initialize_opentelemetry_tracer_provider
from phoenix.trace.schemas import Span
from phoenix.utilities.client import PHOENIX_SERVER_VERSION_HEADER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid this import to keep server and client easily separable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's easy to separate either way, it's a constant, this is just a way to coordinate on the name. I'd argue that on the hierarchy of couplings we need untangle when making new packages a single name import has never made separating work into a package more or less difficult

src/phoenix/utilities/client.py Outdated Show resolved Hide resolved
src/phoenix/utilities/client.py Outdated Show resolved Hide resolved
src/phoenix/utilities/client.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 24, 2024
@anticorrelator anticorrelator merged commit 8454183 into main Jul 25, 2024
11 checks passed
@anticorrelator anticorrelator deleted the dustin/version-mismatch-checks branch July 25, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Detect that the client / server versions mismatch drastically and log a warning
3 participants