feat: Version mismatch checks #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
RogerHYang
reviewed
Jul 24, 2024
RogerHYang
reviewed
Jul 24, 2024
RogerHYang
reviewed
Jul 24, 2024
RogerHYang
approved these changes
Jul 24, 2024
axiomofjoy
approved these changes
Jul 24, 2024
| @@ -87,6 +87,7 @@ | |||
| from phoenix.server.grpc_server import GrpcServer | |||
| from phoenix.server.telemetry import initialize_opentelemetry_tracer_provider | |||
| from phoenix.trace.schemas import Span | |||
| from phoenix.utilities.client import PHOENIX_SERVER_VERSION_HEADER | |||
There was a problem hiding this comment.
Can we avoid this import to keep server and client easily separable?
There was a problem hiding this comment.
it's easy to separate either way, it's a constant, this is just a way to coordinate on the name. I'd argue that on the hierarchy of couplings we need untangle when making new packages a single name import has never made separating work into a package more or less difficult
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3937