feat(trace): add a span aside with timing info and feedback #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
mikeldking
force-pushed
the
mikeldking/4029-span-details
branch
from
c1bc504
to
eaaef2f
Compare
mikeldking
changed the title
| () => (endTime ? new Date(endTime) : null), | ||
| [endTime] | ||
| ); | ||
| const latencyMs = useMemo(() => { |
There was a problem hiding this comment.
yup, I think it should be there
| const spanInfoWrapCSS = css` | ||
| flex: 1 1 auto; | ||
| overflow-y: auto; | ||
| // Overflow fails to take into account padding |
There was a problem hiding this comment.
could this be solved with box-sizing or something?
There was a problem hiding this comment.
I tried box-sizing and it's not working. Not sure why
Parker-Stafford
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4029
Adds a span aside section that can be collapsed that contains timing info. Will add annotations next.
