Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add sort order argument to Span- and Trace- Annotation fields #4079

Merged
merged 2 commits into from
Jul 30, 2024
Merged

feat: Add sort order argument to Span- and Trace- Annotation fields #4079

merged 2 commits into from
Jul 30, 2024

Conversation

anticorrelator
Copy link
Contributor

@anticorrelator anticorrelator commented Jul 30, 2024 •
edited
Loading

resolves #3962

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 30, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 30, 2024
mikeldking
mikeldking approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@mikeldking mikeldking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anticorrelator anticorrelator merged commit cf3b37c into main Jul 30, 2024
12 checks passed
@anticorrelator anticorrelator deleted the dustin/add-sort-order-to-annotations branch July 30, 2024 21:21
@mikeldking mikeldking mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[annotations][gql] annotation sort dir parameter
2 participants
@anticorrelator @mikeldking