Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add raise keyword before exceptions in experiments.types #4080

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: add raise keyword before exceptions in experiments.types #4080

merged 1 commit into from
Jul 30, 2024

Conversation

caroger
Copy link
Contributor

@caroger caroger commented Jul 30, 2024 •
edited
Loading

couple ValueError in post init functions under experiments/types.py are missing the raise keywords

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@caroger caroger changed the title add raise keyword before execptions fix: add raise keyword before exceptions in experiments.types Jul 30, 2024
RogerHYang
RogerHYang approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@RogerHYang RogerHYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@caroger
Copy link
Contributor Author

caroger commented Jul 30, 2024

I have read the CLA Document and I hereby sign the CLA

@RogerHYang
Copy link
Contributor

recheck

github-actions bot added a commit that referenced this pull request Jul 30, 2024
@github-actions
@caroger has signed the CLA in #4080
bdd05f4
@RogerHYang RogerHYang merged commit 4331fdd into Arize-ai:main Jul 30, 2024
8 of 10 checks passed
@mikeldking mikeldking mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerHYang RogerHYang RogerHYang approved these changes

Assignees
No one assigned
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caroger @RogerHYang