feat(ui): condensed trace tree #4099
Conversation
dosubot
bot
added
the
size:L
| icon = isFilled ? <RerankerFilledSVG /> : <RerankerSVG />; | ||
| break; | ||
| case "evaluator": | ||
| color = "--ac-global-color-indigo-1000"; | ||
| color = isDark | ||
| ? "--ac-global-color-indigo-1000" |
There was a problem hiding this comment.
was the rotation not enough with the new filled icons?
There was a problem hiding this comment.
yeah they get super dark. I adjusted them manually with Andy. I think this is necessary overall to make light mode look good
| ) : null} | ||
| <SpanTreeEdge {...leafNode.span} /> | ||
| <SpanTreeEdge {...leafNode.span} nestingLevel={nestingLevel} /> |
There was a problem hiding this comment.
why is the edges level not incremented? because the connection between the two spans should be a the current spans level not the next?
There was a problem hiding this comment.
Because it's the edge of the curve at the current level. It's the little rounding on the left of the icon
| top: 0; | ||
| left: -22px; | ||
| left: ${nestingLevel * NESTING_INDENT + 29}px; |
There was a problem hiding this comment.
some of thee numbers are pretty magical, this is just to get everything to line up correct?
There was a problem hiding this comment.
so the nesting level is how deep you are in the tree. That automatically pushes the start of the icon in by the amount we want each icon to indent. the 29 makes up for the initial margin (16) + border (4) + half the distance of the icon (10) - 1 for some spacing. I can try to write it out but honestly it's sorta easier to adjust and make sure the math is vaguely right. LMK - happy to make the calcs be variable based.
resolves #4027
New condensed span tree with collapse controls per span.
