-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(annotations): show all annotations in annotation summary in project page header #4119
Conversation
project: node(id: $projectId) { | ||
... on Project { | ||
...ProjectPageHeader_stats | ||
...AnnotationSummaryValueFragment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refetch _stats to get a potentially net new annotation name (not using a pre-existing one) refetch ...ValueFragment to get updated information when a new annotation is created with a pre-existing name
) { | ||
deleteSpanAnnotations(input: { annotationIds: [$annotationId] }) { | ||
query { | ||
node(id: $spanId) { | ||
project: node(id: $projectId) { | ||
...ProjectPageHeader_stats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above but in reverse - refetch stats to potentially remove the only instance of an annotation using a particular name
refetch ValueFragment to update the stats associated with a particular annotation name
const { projectId } = useParams(); | ||
const { timeRange } = useLastNTimeRange(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't assume this UI is nested under a project. this UI is also visible under experiments. I think we just let the auto-refresh take care of things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto refresh as in the streaming? i can remove these spreads then, i wasn't seeing the annotations bar update though but i had streaming off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
note the page header refresh is currently broken due to a lack of cache busting on the server ticket #4120 - @anticorrelator to update - above was tested with no server side cache to verify refetch worked properly
Screen.Recording.2024-08-02.at.10.57.05.AM.mov