Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] [Authorization] [Oauth] client.get_dataset_versions does not support Authentication #4131

Open
carlosmagan opened this issue Aug 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@carlosmagan
Copy link

Describe the bug
The client.get_dataset_versions method does not handle authentication properly.

In this method we have a plain httpx request that does not include headers, therefore authorization is not supported returning a 401 Unauthorized.
response = httpx.get(url=url, params={"limit": limit})
This method should use the method self._client.get in an analogous way to the get_dataset method

response = self._client.get(
            urljoin(self._base_url, f"v1/datasets/{dataset_id}/versions"),
            params={"limit": limit},
        )

To Reproduce
Steps to reproduce the behavior:

  1. Deploy phoenix on a secure environment that requires Oauth authentication
  2. Upload a dataset
  3. Instantiate a phoenix client in a notebook
  4. Query the dataset with the get_dataset_versions method

Expected behavior
get_dataset_versions should handle authorization properly, returning the dataset versions when the client uses Oauth authentication.

Screenshots
Failed behavior:
image
Expected behavior:
image

@carlosmagan carlosmagan added bug Something isn't working triage issues that need triage labels Aug 5, 2024
@axiomofjoy
Copy link
Contributor

@carlosmagan Thanks for using Phoenix. We hear you on the need for authentication and are beginning work on this here.

phoenix.Client does not currently support OAuth2, so I am relabeling this as an enhancement request rather than a bug. Please let us know if you have any suggestions for auth-related features you'd like to see.

@axiomofjoy axiomofjoy added enhancement New feature or request and removed bug Something isn't working triage issues that need triage labels Aug 5, 2024
@axiomofjoy axiomofjoy changed the title [BUG] [Client] [Authorization] [Oauth] client.get_dataset_versions does not support Authentication [Client] [Authorization] [Oauth] client.get_dataset_versions does not support Authentication Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📘 Todo
Development

No branches or pull requests

2 participants