Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth] add validation checks for PHOENIX_SECRET to ensure a strong symmetric key is used #4177

Closed
Tracked by #3433
axiomofjoy opened this issue Aug 8, 2024 · 3 comments
Closed
Tracked by #3433

[auth] add validation checks for PHOENIX_SECRET to ensure a strong symmetric key is used #4177

axiomofjoy opened this issue Aug 8, 2024 · 3 comments
Assignees
@RogerHYang

Comments

@axiomofjoy
Copy link
Contributor

axiomofjoy commented Aug 8, 2024 •
edited
Loading

E.g., ensure the users passes in a 256-bit symmetric key.
@axiomofjoy axiomofjoy mentioned this issue Aug 8, 2024
Closed
@axiomofjoy axiomofjoy changed the title [auth] add validation checks for PHOENIX_SECRET to ensure a strong symmetric key [auth] add validation checks for PHOENIX_SECRET to ensure a strong symmetric key is used Aug 8, 2024
@mikeldking
Copy link
Contributor

Maybe just a warning?

@axiomofjoy
Copy link
Contributor Author

Maybe a length check as well.

@mikeldking
Copy link
Contributor

I think the error message could still be a bit clearer

@RogerHYang RogerHYang mentioned this issue Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RogerHYang RogerHYang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikeldking @axiomofjoy @RogerHYang