Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add login/ logout routes and createUser mutation #4293

Merged
merged 8 commits into from
Aug 21, 2024

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Aug 20, 2024

Adds /login and /logout routes and a createUser mutation. Adds helper functions for verifying user credentials.

resolves #4037
resolves #4045

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 20, 2024
@axiomofjoy axiomofjoy force-pushed the xander/password-salting-and-hashing branch from c8826e2 to 3af58b7 Compare August 20, 2024 21:03
Copy link
Contributor

@RogerHYang RogerHYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to have an e2e test for the workflow, i.e. create then login

src/phoenix/auth.py Outdated Show resolved Hide resolved
@axiomofjoy axiomofjoy force-pushed the xander/password-salting-and-hashing branch from 904dc40 to 5dd9a86 Compare August 20, 2024 23:51
@axiomofjoy axiomofjoy force-pushed the xander/password-salting-and-hashing branch from 807a913 to 8128f1a Compare August 21, 2024 01:07
@axiomofjoy axiomofjoy force-pushed the xander/password-salting-and-hashing branch from 8128f1a to 1aa5553 Compare August 21, 2024 02:27
@axiomofjoy axiomofjoy merged commit a3ff0f6 into main Aug 21, 2024
12 checks passed
@axiomofjoy axiomofjoy deleted the xander/password-salting-and-hashing branch August 21, 2024 04:01
fjcasti1 added a commit that referenced this pull request Aug 21, 2024
* main:
  ci(python): increase timeout for integration test (#4306)
  chore(main): release arize-phoenix 4.26.0 (#4299)
  fix: postgresql driver name for db migrations (#4304)
  feat(auth): add login/ logout routes and createUser mutation (#4293)
  chore(main): release arize-phoenix 4.25.0 (#4251)
  fix(python): application launch on Windows (#4276)
  ci: exclude buggy scipy version (#4298)
  chore(main): release arize-phoenix-otel 0.3.0 (#4297)
  feat: Improve OTel wrapper ergonomics (#4295)
  feat(auth): add expiry support for system keys (#4296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[auth][rest] public login and logout routes [auth][graphql] createUser resolver
3 participants