feat: Improve OTel wrapper ergonomics #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
mikeldking
reviewed
Aug 20, 2024
Comment on lines
+140
to
+143
| if os.name == "nt": | ||
| details_header = "OpenTelemetry Tracing Details" | ||
| else: | ||
| details_header = "🔭 OpenTelemetry Tracing Details 🔭" |
There was a problem hiding this comment.
should the guard be just for windows?
There was a problem hiding this comment.
The current guard is only for Windows, are we worried about anything else? (cc @RogerHYang)
mikeldking
approved these changes
Aug 20, 2024
|
|
||
| def register( | ||
| *, | ||
| endpoint: Optional[str] = None, | ||
| project_name: Optional[str] = None, | ||
| batch: bool = False, | ||
| set_global=True, | ||
| headers=None, | ||
| set_global_tracer: bool = True, |
There was a problem hiding this comment.
Suggested change
| set_global_tracer: bool = True, | |
| set_global_tracer_provider: bool = True, |
I guess more explicit maybe
| set_global=True, | ||
| headers=None, | ||
| set_global_tracer: bool = True, | ||
| headers: Optional[Dict[str, str]] = None, |
There was a problem hiding this comment.
Should verbose be plumbed through here too?
| return exporter.__class__.__name__ | ||
|
|
||
|
|
||
| def _normalize_headers(headers: Union[List[Tuple[str, str]], Dict[str, str]]) -> Dict[str, str]: |
There was a problem hiding this comment.
Normalize is probably not the right word. It's just for printing so maybe something like
phoenix/src/phoenix/db/engines.py
Line 32 in ce00d50
fjcasti1
added a commit
that referenced
this pull request
Aug 21, 2024
* main: ci(python): increase timeout for integration test (#4306) chore(main): release arize-phoenix 4.26.0 (#4299) fix: postgresql driver name for db migrations (#4304) feat(auth): add login/ logout routes and createUser mutation (#4293) chore(main): release arize-phoenix 4.25.0 (#4251) fix(python): application launch on Windows (#4276) ci: exclude buggy scipy version (#4298) chore(main): release arize-phoenix-otel 0.3.0 (#4297) feat: Improve OTel wrapper ergonomics (#4295) feat(auth): add expiry support for system keys (#4296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://localhost:6006