feat(auth): add create user modal to ui #4319
Conversation
dosubot
bot
added
the
size:XL
| disabled={!isDirty} | ||
| // Only allow submission if the form is dirty for edits | ||
| // When creating allow the user to click create without any changes as the form will be prefilled with valid values | ||
| disabled={formMode === "edit" ? !isDirty : false} |
There was a problem hiding this comment.
this was something i noticed, this !isDirty made it so a user had to make edits in the create flow - was originally added so that updates couldn't just be spam clicked
| user { | ||
| id | ||
| } |
There was a problem hiding this comment.
@mikeldking i did not have luck with datasets in spreading fragments that fetched connections and getting the fragment to refetch so i did not add query type onto the return here and am instead using fetchKey - let me know if i'm missing someting but connections don't seem to be refetchable like that? https://relay.dev/docs/tutorial/mutations-updates/#adding-comments--mutations-on-connections - although users table doesn' thave the connection directive so maybe it would work here...
There was a problem hiding this comment.
Yeah I'm struggling with this as well. We can maybe use relay's optimistic updates instead. Then things will be better encapsulated
There was a problem hiding this comment.
yeah i'm not sure if optimistic updates work for connections, i might just try the connection directives - i had trouble last time but maybe i can get it to work here
| @@ -67,6 +68,7 @@ export function UsersTable() { | |||
| ], | |||
| data: tableData, | |||
| getCoreRowModel: getCoreRowModel(), | |||
| getSortedRowModel: getSortedRowModel(), | |||
There was a problem hiding this comment.
enables sorting to work, icons were showing up but wasn't sorting
| import { UserRole } from "@phoenix/constants"; | ||
|
|
||
| const UserRoles = Object.values(UserRole); |
There was a problem hiding this comment.
I'd sorta prefer to make this use the API to get the roles. It might be some overhead right now but ultimately a tad more flexible and honest
There was a problem hiding this comment.
That works for me, i can make a follow up to do that
| user { | ||
| id | ||
| } |
There was a problem hiding this comment.
Yeah I'm struggling with this as well. We can maybe use relay's optimistic updates instead. Then things will be better encapsulated
| export enum UserRole { | ||
| ADMIN = "ADMIN", | ||
| MEMBER = "MEMBER", | ||
| } |
There was a problem hiding this comment.
I always debate whether or not enums for this kinda thing is worth the effort. I know we do it a fair amount - non-blocking but when something can be expressed as string literal types very simply it begs the question a bit
There was a problem hiding this comment.
i'll pull from the server - then we can get rid of this I think
resolve #4278
Screen.Recording.2024-08-21.at.4.42.03.PM.mov