Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding): New project onboarding #4372

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Aug 23, 2024

resolves #4268

Adds project onboarding for python and javascript. Accounts for hosting as well.

Screenshot 2024-08-26 at 10 59 51 AM Screenshot 2024-08-26 at 12 08 12 PM Screenshot 2024-08-26 at 12 43 57 PM

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 23, 2024
@mikeldking mikeldking marked this pull request as draft August 23, 2024 21:42
app/src/config.ts Fixed Show fixed Hide fixed
app/src/config.ts Fixed Show fixed Hide fixed
@mikeldking mikeldking marked this pull request as ready for review August 26, 2024 20:20
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
projectName?: string;
};

const PHOENIX_OTEL_DOC_LINK =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a corresponding ts docs link like the ones above for python?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's super bare-bones right now - gotta work with you on the TS docs side of things

Copy link
Contributor

@Parker-Stafford Parker-Stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty project/index.ts file!

@mikeldking mikeldking merged commit 16ac5ed into main Aug 26, 2024
6 checks passed
@mikeldking mikeldking deleted the 4268-project-onboarding branch August 26, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[onboarding] project onboarding
2 participants