feat(auth): refresh route and auth router refactor #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axiomofjoy
force-pushed
the
auth-router
branch
4 times, most recently
from
6f4058e
to
3aa7a93
Compare
dosubot
bot
added
the
size:XXL
RogerHYang
force-pushed
the
auth
branch
2 times, most recently
from
03a5ad0
to
dc21f70
Compare
axiomofjoy
force-pushed
the
auth-router
branch
from
7857c9b
to
c64ef86
Compare
axiomofjoy
force-pushed
the
auth-router
branch
from
c64ef86
to
fa2ef19
Compare
mikeldking
reviewed
Sep 4, 2024
mikeldking
reviewed
Sep 4, 2024
mikeldking
reviewed
Sep 4, 2024
| password_is_valid = partial( | ||
| is_valid_password, password=password, salt=salt, password_hash=password_hash | ||
| ) | ||
| if not await loop.run_in_executor(None, password_is_valid): |
There was a problem hiding this comment.
kinda confused by this. Why do you need to run in the loop here?
There was a problem hiding this comment.
computing the password hash is by design an expensive operation to mitigate against brute-force attacks. this is an optimization to run the computation in a background thread and yield control of the event loop while it is being computed.
mikeldking
reviewed
Sep 4, 2024
mikeldking
approved these changes
Sep 4, 2024
Co-authored-by: Mikyo King <mikyo@arize.com>
This was referenced Sep 4, 2024
RogerHYang
pushed a commit
that referenced
this pull request
Sep 21, 2024
Co-authored-by: Dustin Ngo <dustin@arize.com>
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4433