Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Improve namespace packaging #4603

Closed
ewianda opened this issue Sep 12, 2024 · 0 comments · Fixed by #4643
Closed

[ENHANCEMENT] Improve namespace packaging #4603

ewianda opened this issue Sep 12, 2024 · 0 comments · Fixed by #4643
Assignees
Labels
enhancement New feature or request

Comments

@ewianda
Copy link

ewianda commented Sep 12, 2024

Is your feature request related to a problem? Please describe.
The bazel python ruleset relies on the standards for laying out name space packages. The existing setup doesn't follow that as such it is not possible to have both the core and the eval packages in the same bazel managed code based
Describe the solution you'd like
Ensure that top level packages have no __init__.py files or include the __path__ = __import__('pkgutil').extend_path(__path__, __name__) in the init.py files

Additional context
Similar issue was reported previously
Arize-ai/openinference#398

@ewianda ewianda added enhancement New feature or request triage issues that need triage labels Sep 12, 2024
@RogerHYang RogerHYang self-assigned this Sep 13, 2024
@RogerHYang RogerHYang removed the triage issues that need triage label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants