feat: Wire up API keys via env var for Phoenix clients and experiments #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
mikeldking
reviewed
Sep 13, 2024
dosubot
bot
added
size:M
mikeldking
reviewed
Sep 16, 2024
anticorrelator
commented
Sep 16, 2024
mikeldking
reviewed
Sep 16, 2024
src/phoenix/utilities/client.py
Outdated
| self.headers.update(env_headers) | ||
| if "authorization" not in [k.lower() for k in self.headers]: | ||
| if api_key := get_env_phoenix_api_key(): | ||
| self.headers["authorization"] = f"Bearer {api_key}" |
There was a problem hiding this comment.
Suggested change
| self.headers["authorization"] = f"Bearer {api_key}" | |
| self.headers["Authorization"] = f"Bearer {api_key}" |
mikeldking
approved these changes
Sep 16, 2024
dosubot
bot
added
size:S
RogerHYang
pushed a commit
that referenced
this pull request
Sep 21, 2024
#4617) * feat: Wire up API keys via env var for Phoenix clients and experiments * Unify header management * Capitalize `authorization` header key * Capitalization shouldn't matter * Recapitalize b/c REST
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4613