-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): add admin user management ui #4631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
This PR changes 500-999 lines, ignoring generated files.
label
Sep 16, 2024
mikeldking
reviewed
Sep 17, 2024
mikeldking
requested changes
Sep 17, 2024
Parker-Stafford
force-pushed
the
parker/4569-admin-user-management
branch
from
September 17, 2024 22:29
39aa078
to
16f5a07
Compare
mikeldking
reviewed
Sep 18, 2024
Comment on lines
+61
to
+63
enum AuthMethod { | ||
LOCAL | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @axiomofjoy
mikeldking
reviewed
Sep 18, 2024
mikeldking
approved these changes
Sep 18, 2024
Parker-Stafford
force-pushed
the
parker/4569-admin-user-management
branch
from
September 18, 2024 17:27
f41a5c7
to
2f3052c
Compare
RogerHYang
pushed a commit
that referenced
this pull request
Sep 21, 2024
* feat(auth): add admin user management ui * block changing admins role, block resetting password when not using local auth * remove user form changes * remove blocked wording for user delete
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4612
Screen.Recording.2024-09-16.at.4.55.50.PM.mov