fix: inadvertent cookie deletion when changing user password via PatchUser #4637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
mikeldking
reviewed
Sep 17, 2024
| @@ -145,9 +143,6 @@ async def hash_password(password: str, salt: bytes) -> bytes: | |||
| async def log_out(self, user_id: int) -> None: | |||
| assert self.token_store is not None | |||
| await self.token_store.log_out(UserId(user_id)) | |||
| response = self.get_response() | |||
There was a problem hiding this comment.
I think to make this clearer you could name the method log_out_user - then it's clear that you are not logging out the current user
There was a problem hiding this comment.
Since it already takes an argument it's a bit redundant at the call site, e.g.
log_out(user.id)vs.
log_out_user(user.id)There was a problem hiding this comment.
the inclusion of cookies was an oversight because it was an overstep of single responsibility
mikeldking
approved these changes
Sep 17, 2024
RogerHYang
added a commit
that referenced
this pull request
Sep 21, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.