Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth][cleanup] fully delete user tuples #4676

Closed
Tracked by #3433
axiomofjoy opened this issue Sep 19, 2024 · 0 comments · Fixed by #4715
Closed
Tracked by #3433

[auth][cleanup] fully delete user tuples #4676

axiomofjoy opened this issue Sep 19, 2024 · 0 comments · Fixed by #4715
Assignees

Comments

@axiomofjoy
Copy link
Contributor

axiomofjoy commented Sep 19, 2024

We currently have an optional deleted_at timestamp field in the users table of the database that we add a value to when a user is deleted. Since we also have a unique constraint on email, this means that once a user has deleted their account, the email is no longer usable in Phoenix. This problem is exacerbated with our OAuth2 integration, since it means that a user has no way to log with their IDP if they have already used the corresponding email to create a local account.

We need to remove the deleted_at column and actually delete user tuples to resolve this issue. For reference, we want to undo the changes that were made in this PR.

@axiomofjoy axiomofjoy changed the title [auth][oauth] fully delete user tuples [auth][cleanup] fully delete user tuples Sep 19, 2024
@axiomofjoy axiomofjoy self-assigned this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant