Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove exp from jwt #4729

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: remove exp from jwt #4729

merged 2 commits into from
Sep 25, 2024

Conversation

RogerHYang
Copy link
Contributor

It's not being used. Removal shortens the token character length.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 24, 2024
@RogerHYang RogerHYang changed the title fix: remove exp from jwt fix: remove exp from jwt Sep 24, 2024
@@ -244,8 +244,6 @@ def __init__(

def _encode(self, claim: ClaimSet) -> str:
payload: Dict[str, Any] = dict(jti=claim.token_id)
if claim.expiration_time:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes useful if you want to do client-side checks. NBD

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
@mikeldking mikeldking merged commit 0e6e1e8 into auth Sep 25, 2024
16 checks passed
@mikeldking mikeldking deleted the remove-exp-from-jwt branch September 25, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants