fix: add middleware for checking Cross-Site Request Forgery (CSRF) when trusted origins are specified via environment variable #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
RogerHYang
commented
Oct 8, 2024
src/phoenix/config.py
Outdated
| @@ -107,6 +107,11 @@ | |||
| """ | |||
| The duration, in minutes, before password reset tokens expire. | |||
| """ | |||
| ENV_PHOENIX_CSRF_TRUSTED_ORIGINS = "CSRF_TRUSTED_ORIGINS" | |||
There was a problem hiding this comment.
see CSRF_TRUSTED_ORIGINS from grafana
axiomofjoy
reviewed
Oct 8, 2024
axiomofjoy
reviewed
Oct 8, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
axiomofjoy
approved these changes
Oct 9, 2024
RogerHYang
force-pushed
the
csrf-trusted-origins
branch
2 times, most recently
from
e61c4ae
to
34ce718
Compare
RogerHYang
force-pushed
the
csrf-trusted-origins
branch
from
34ce718
to
711bceb
Compare
RogerHYang
changed the title
RogerHYang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4883