fix(playground): ignore keyboard events in template messages for drag and drop #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
Parker-Stafford
commented
Oct 10, 2024
dosubot
bot
added
size:L
Parker-Stafford
commented
Oct 10, 2024
| @@ -32,22 +55,31 @@ export function PlaygroundChatTemplate(props: PlaygroundChatTemplateProps) { | |||
| throw new Error(`Invalid template type ${template.__type}`); | |||
| } | |||
|
|
|||
| const sensors = useSensors( | |||
There was a problem hiding this comment.
this is not necessary but does make the keyboard sorting much much better, can remove if we don't care
Parker-Stafford
commented
Oct 10, 2024
| @@ -5,7 +5,8 @@ export type GenAIOperationType = "chat" | "text_completion"; | |||
|
|
|||
| let playgroundInstanceIdIndex = 0; | |||
| let playgroundRunIdIndex = 0; | |||
| let playgroundMessageIdIndex = 0; | |||
| // This value must be truthy in order for message re-ordering to work | |||
| let playgroundMessageIdIndex = 1; | |||
There was a problem hiding this comment.
didn't bottom this out but an item with id of 0 is not draggable, assume there is some if(id) check going on somewhere
Parker-Stafford
force-pushed
the
parker/fix-dnd-keyboard
branch
from
464b228
to
e8e90db
Compare
mikeldking
reviewed
Oct 10, 2024
Comment on lines
+75
to
+77
| if (!over || active.id === over.id) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
can you help me understand this?
There was a problem hiding this comment.
if the dragged element not over any other element, or it's over itself, no need to reorder the list so we cut out early, pulled this from an example, probably works without it, just an optimization i suppose
mikeldking
approved these changes
Oct 10, 2024
mikeldking
pushed a commit
that referenced
this pull request
Oct 11, 2024
… and drop (#4945) * fix(playground): ignore keyboard events in template messages for drag and drop * pull default pointer sensor from dnd-kit/dom * update file name casing via git * migrate to non-experimental dnd-kit * remove unused experimental code, update naming and remove unnecessary props * remove strategy * fix forward ref warning
Parker-Stafford
added a commit
that referenced
this pull request
Oct 11, 2024
… and drop (#4945) * fix(playground): ignore keyboard events in template messages for drag and drop * pull default pointer sensor from dnd-kit/dom * update file name casing via git * migrate to non-experimental dnd-kit * remove unused experimental code, update naming and remove unnecessary props * remove strategy * fix forward ref warning
mikeldking
pushed a commit
that referenced
this pull request
Oct 11, 2024
… and drop (#4945) * fix(playground): ignore keyboard events in template messages for drag and drop * pull default pointer sensor from dnd-kit/dom * update file name casing via git * migrate to non-experimental dnd-kit * remove unused experimental code, update naming and remove unnecessary props * remove strategy * fix forward ref warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where typing a space or enter on while in the text field caused the keyboard event to get swallowed by dnd-kit and switch to drag mode.
Fixed by migrating to dnd-kit non experimental
Typing / mouse and keyboard drag and drop
Screen.Recording.2024-10-10.at.3.55.28.PM.mov