Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): add / delete messages #4947

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

mikeldking
Copy link
Contributor

Add the ability to add / remove messages

Screen.Recording.2024-10-10.at.2.12.43.PM.mov

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 10, 2024
@@ -141,6 +210,10 @@ function SortableMessageItem({
}
}
`}
onKeyDownCapture={(e) => {
// Don't bubble up any keyboard events from the text area as to not interfere with DND
e.stopPropagation();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked at onKeyDown but didn't look into onKeyDownCapture, much simpler fix than what i had

@mikeldking mikeldking merged commit b65ddeb into playground Oct 10, 2024
7 checks passed
@mikeldking mikeldking deleted the add-delete-message branch October 10, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants