feat: Add model listing #4948
Merged
feat: Add model listing #4948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
| async def model_providers( | ||
| self, vendors: List[str], info: Info[Context, None] | ||
| ) -> List[ModelProvider]: | ||
| all_vendors = { |
There was a problem hiding this comment.
Pythony question is there any reason to define this constant inside of a function instead of statically somewhere?
There was a problem hiding this comment.
Yeah it could be hoisted. But probably needs a refactor anyway
mikeldking
reviewed
Oct 11, 2024
| ) -> List[ModelProvider]: | ||
| all_vendors = { | ||
| "OpenAI": ModelProvider( # https://platform.openai.com/docs/models | ||
| name="OpenAI", # currently only models using the chat completions API |
There was a problem hiding this comment.
since this will have to be a graphql input param, it might make more sense to start with the vendor being a graphql enum
mikeldking
approved these changes
Oct 11, 2024
mikeldking
force-pushed
the
playground
branch
from
cf18e34
to
5990585
Compare
anticorrelator
force-pushed
the
dustin/add-model-listing
branch
from
04e681c
to
a3d2a4e
Compare
mikeldking
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Add query for model providers * gql build * Hardcode all models for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially resolves #4858
Adds amodel_providersquery that lists available models given a specific provider as an input. This is currently incomplete, as I plan to add a DB-backed store for snapshotted models. I think it feels too bad to tie model definitions to the server version.Hardcodes all models for now