Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): allow up to 4 instances, distinguish alphabetically #4951

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

mikeldking
Copy link
Contributor

resolves #4949

Allows up to 4 instances to be added, distinguishes them by alphabetic "index"

Screenshot 2024-10-10 at 4 01 33 PM

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 10, 2024
Copy link
Contributor

@cephalization cephalization left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

We get this error on value change but I can fix that when I merge the codemirror editor

image

@Parker-Stafford
Copy link
Contributor

Looks great.

We get this error on value change but I can fix that when I merge the codemirror editor

image

I have a fix in here
#4945

@mikeldking mikeldking merged commit c108625 into playground Oct 10, 2024
7 checks passed
@mikeldking mikeldking deleted the alphabet-instance-indicators branch October 10, 2024 23:19
mikeldking added a commit that referenced this pull request Oct 11, 2024
…#4951)

* WIP

* feat(playground): allow up to 4 playground instances, distinguish alphabetically
mikeldking added a commit that referenced this pull request Oct 11, 2024
…#4951)

* WIP

* feat(playground): allow up to 4 playground instances, distinguish alphabetically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants