Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): add credential storage #4970

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

Parker-Stafford
Copy link
Contributor

@Parker-Stafford Parker-Stafford commented Oct 11, 2024

resolves #4885

Screen.Recording.2024-10-11.at.3.14.16.PM.mov

@Parker-Stafford Parker-Stafford force-pushed the parker/4885-playground-credentials branch from 8ea1b20 to ce6524d Compare October 11, 2024 22:16
@Parker-Stafford Parker-Stafford marked this pull request as ready for review October 11, 2024 22:23
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 11, 2024
Copy link
Contributor

@cephalization cephalization left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test it but code and video both look good!

@Parker-Stafford Parker-Stafford force-pushed the parker/4885-playground-credentials branch from fc8929e to 551d0d6 Compare October 14, 2024 16:45
@Parker-Stafford Parker-Stafford merged commit b15f2a4 into playground Oct 14, 2024
7 checks passed
@Parker-Stafford Parker-Stafford deleted the parker/4885-playground-credentials branch October 14, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants