Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): playground layout #4978

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Oct 12, 2024

new playground layout and moves input to be shared across instances.

Screenshot 2024-10-14 at 11 16 44 AM

@mikeldking mikeldking marked this pull request as ready for review October 14, 2024 17:22
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 14, 2024
Comment on lines +69 to +81
<Button
variant="default"
size="compact"
aria-label="add prompt"
icon={<Icon svg={<Icons.PlusCircleOutline />} />}
disabled={numInstances >= NUM_MAX_PLAYGROUND_INSTANCES}
onClick={() => {
addInstance();
}}
>
Prompt
</Button>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'm not seeing this button

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you need to bump your deps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. Weird, let me nuke node modules

{instances.map((instance, i) => (
<View key={i} flex="1 1 0px">
<PlaygroundOutput
key={i}
Copy link
Contributor

@Parker-Stafford Parker-Stafford Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need key here or above on the nested elements

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@mikeldking mikeldking merged commit 2c50441 into playground Oct 14, 2024
7 checks passed
@mikeldking mikeldking deleted the playground-layout branch October 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants