feat(playground): playground layout #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeldking
force-pushed
the
playground-layout
branch
from
70dedcb
to
82f8986
Compare
mikeldking
force-pushed
the
playground-layout
branch
from
82f8986
to
0255b58
Compare
dosubot
bot
added
the
size:L
mikeldking
commented
Oct 14, 2024
Comment on lines
+69
to
+81
| <Button | ||
| variant="default" | ||
| size="compact" | ||
| aria-label="add prompt" | ||
| icon={<Icon svg={<Icons.PlusCircleOutline />} />} | ||
| disabled={numInstances >= NUM_MAX_PLAYGROUND_INSTANCES} | ||
| onClick={() => { | ||
| addInstance(); | ||
| }} | ||
| > | ||
| Prompt | ||
| </Button> | ||
| </div> |
There was a problem hiding this comment.
I'm not seeing this button
There was a problem hiding this comment.
Yeah you need to bump your deps
There was a problem hiding this comment.
I did. Weird, let me nuke node modules
| {instances.map((instance, i) => ( | ||
| <View key={i} flex="1 1 0px"> | ||
| <PlaygroundOutput | ||
| key={i} |
There was a problem hiding this comment.
don't need key here or above on the nested elements
Parker-Stafford
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new playground layout and moves input to be shared across instances.