Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): Implement editable input variable textareas (#4987) #5006

Merged

Conversation

cephalization
Copy link
Contributor

@cephalization cephalization commented Oct 15, 2024

Better.variable.fields.mov

Uses codemirror without lang and with line wrapping.
Additionally, implements a variable value cache so that variable values stick around when changing syntax type or variable name.

@cephalization cephalization force-pushed the cephalization/playground-edit-input-variables branch from 748d041 to d916733 Compare October 15, 2024 15:54
@cephalization cephalization marked this pull request as ready for review October 15, 2024 19:44
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 15, 2024
Copy link
Contributor

@Parker-Stafford Parker-Stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@cephalization cephalization force-pushed the cephalization/playground-edit-input-variables branch from 00371ee to ab07d75 Compare October 15, 2024 22:45
@cephalization cephalization merged commit ab09109 into playground Oct 15, 2024
7 checks passed
@cephalization cephalization deleted the cephalization/playground-edit-input-variables branch October 15, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants