-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playground): tool call backend #5027
Conversation
291f283
to
805c5ee
Compare
class FunctionCallChunk: | ||
name: str | ||
arguments: str | ||
|
||
|
||
@strawberry.type | ||
class ToolCallChunk: | ||
id: str | ||
function: FunctionCallChunk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the function field actually being chunked? or are you just yielding a toolcallchunk with the function field growing each time? That is, is there nested chunking happening here? If not the naming might be a bit confusing but i don't have a better thought, this is probably fine just curious of the mechanics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the arguments being chunked. could call it just FunctionCall
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could work, or just leaving it as is. Either way works for me just a small thing that occurred to me when reading, your call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these types might change when we do the mutation for non-streaming. Going to leave as is for now, I think it probably changes.
resolves #4988