-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow progress bar to be disabled #5064
fix: allow progress bar to be disabled #5064
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
sorry the CI is not working right now. we're still trying to fix it |
Ok. Please try merge main to update CI. Thanks |
d3e9a7b
to
aa0c9e3
Compare
@mgordon-arize Can you sign the CLA? |
if self.tqdm_bar_format is None: | ||
progress_bar = tqdm(total=len(inputs), bar_format=self.tqdm_bar_format, disable=True) | ||
else: | ||
progress_bar = tqdm(total=len(inputs), bar_format=self.tqdm_bar_format) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (same for the other location)
if self.tqdm_bar_format is None: | |
progress_bar = tqdm(total=len(inputs), bar_format=self.tqdm_bar_format, disable=True) | |
else: | |
progress_bar = tqdm(total=len(inputs), bar_format=self.tqdm_bar_format) | |
progress_bar = tqdm( | |
total=len(inputs), | |
bar_format=self.tqdm_bar_format, | |
disable=self.tqdm_bar_format is None, | |
) |
I have read the CLA Document and I hereby sign the CLA |
0cbb3c7
to
685dd42
Compare
Add new parameter to llm_classify to allow progress bar format to be customizable and to be disabled
This was because the logs were noisy and verbose does not disable the progress bar