fix: allow progress bar to be disabled #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
sorry the CI is not working right now. we're still trying to fix it |
RogerHYang
changed the title
|
Ok. Please try merge main to update CI. Thanks |
mgordon-arize
force-pushed
the
progress-bar-format-update
branch
from
d3e9a7b
to
aa0c9e3
Compare
|
@mgordon-arize Can you sign the CLA? |
RogerHYang
approved these changes
Oct 18, 2024
Comment on lines
228
to
231
| if self.tqdm_bar_format is None: | ||
| progress_bar = tqdm(total=len(inputs), bar_format=self.tqdm_bar_format, disable=True) | ||
| else: | ||
| progress_bar = tqdm(total=len(inputs), bar_format=self.tqdm_bar_format) |
There was a problem hiding this comment.
nit (same for the other location)
Suggested change
| if self.tqdm_bar_format is None: | |
| progress_bar = tqdm(total=len(inputs), bar_format=self.tqdm_bar_format, disable=True) | |
| else: | |
| progress_bar = tqdm(total=len(inputs), bar_format=self.tqdm_bar_format) | |
| progress_bar = tqdm( | |
| total=len(inputs), | |
| bar_format=self.tqdm_bar_format, | |
| disable=self.tqdm_bar_format is None, | |
| ) |
|
I have read the CLA Document and I hereby sign the CLA |
mgordon-arize
force-pushed
the
progress-bar-format-update
branch
from
0cbb3c7
to
685dd42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new parameter to llm_classify to allow progress bar format to be customizable and to be disabled
This was because the logs were noisy and verbose does not disable the progress bar