fix: Derive playground values instead of storing them in state #5067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
Resolves #5060 |
This prevents stale variable inputs from being displayed on the playground.
cephalization
force-pushed
the
cephalization/derived-input-variables
branch
from
2d54301
to
cae060b
Compare
|
To verify the fix, just enter the playground via any span and observe that the inputs tab is not pre-populated with incorrect variables |
axiomofjoy
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents stale variable inputs from being displayed on the playground.
TODO: fix render slowdown. This approach is slower, need to memoize some more things.Performance profiling reveals that dropped frames while typing quickly is due to expensive over-re-rendering. We can fix this later or via react compiler in the future.