feat(playground): add tool role messages to ui #5103
Conversation
| @@ -101,9 +81,9 @@ export type ModelConfig = { | |||
| /** | |||
| * The type of a tool in the playground | |||
| */ | |||
| export type Tool = { | |||
| export type OpenAITool = { | |||
There was a problem hiding this comment.
this is just being more honest in preparation for the conversion from one tool schema to another
| * allow for extra keys when the zod schema is used for parsing. This is to allow more flexibility for users | ||
| * to define their own tool calls according | ||
| */ | ||
| export const openAIToolCallSchema = z.object({ |
There was a problem hiding this comment.
see comment below, trying to nme things more honestly in prep for tool conversion between providers @cephalization
dosubot
bot
added
the
size:XL
|
@Parker-Stafford pushed some minor padding in 12dfaba Looks great. Just need to work on that rebase with @anticorrelator and @axiomofjoy |
|
When you change message role, tools are not reset
|
I noticed this as well, i hado nuke node modules and not frozen install... then it worked |
pnpm claims to be installing new versions, and if I look at my node_modules folder the new components are in src, so I have to wonder if its an issue with our vite dev setup. |
ahh could be i did custom chunking for some of our deps including ui components, i wonder if those are getting cached somehow |
Parker-Stafford
force-pushed
the
parker/5041-tool-messages-ui
branch
from
8c3b239
to
e946c00
Compare
That's some good intuition, sounds like a possible candidate. Will experiment with it this week |
… calls and mode when switching off of ai
| tool_calls: Optional[List[JSON]] = UNSET | ||
| """The tool calls that were made in the message""" | ||
| tool_call_id: Optional[str] = UNSET | ||
| """The ID of the tool call that was made in a prior message""" |
There was a problem hiding this comment.
| """The ID of the tool call that was made in a prior message""" | |
| """The ID of the tool call described in the current message""" |
There was a problem hiding this comment.
this has to match the id of a tool call in a prior message, the wording might be a little confusing right now, but it needs to match a pre-existing tool call id, which would be message.tool_calls.id in a previous message
There was a problem hiding this comment.
I'll try to update a bit
| def to_openai_tool_call_param( | ||
| self, | ||
| tool_calls: List[JSONScalarType], | ||
| ) -> List["ChatCompletionMessageToolCallParam"]: | ||
| from openai.types.chat import ChatCompletionMessageToolCallParam | ||
|
|
||
| return [ | ||
| ChatCompletionMessageToolCallParam( | ||
| id=tool_call.get("id", ""), | ||
| function={ | ||
| "name": tool_call.get("function", {}).get("name", ""), | ||
| "arguments": safe_json_dumps( | ||
| tool_call.get("function", {}).get("arguments", "") | ||
| ), | ||
| }, | ||
| type="function", | ||
| ) | ||
| for tool_call in tool_calls | ||
| ] |
There was a problem hiding this comment.
I would make this input a single tool call and return a single tool call param for the sake of granularity
There was a problem hiding this comment.
ahh sounds good
resolves #5041
Screen.Recording.2024-10-18.at.5.25.58.PM.mov