Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): show span details when playground run ends #5108

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Oct 18, 2024

resolves #5099

token_counts.mp4

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 18, 2024
@mikeldking mikeldking changed the title feat(playground): show span details when playground run ends" feat(playground): show span details when playground run ends Oct 18, 2024
Copy link
Contributor

@cephalization cephalization left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I watched you write it so my approval might be cheating 😄

@mikeldking mikeldking merged commit acce9d9 into main Oct 18, 2024
9 checks passed
@mikeldking mikeldking deleted the 5099-pull-span branch October 18, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[playground] pull span information once the span is completed (e.g. latency, tokens)
2 participants