feat(playground): plumb through tools on spans to playground #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
Parker-Stafford
commented
Oct 25, 2024
| @@ -624,7 +624,7 @@ def _llm_output_messages( | |||
| yield f"{LLM_OUTPUT_MESSAGES}.0.{MESSAGE_ROLE}", "assistant" | |||
| if content := "".join(chunk.content for chunk in text_chunks): | |||
| yield f"{LLM_OUTPUT_MESSAGES}.0.{MESSAGE_CONTENT}", content | |||
| for tool_call_index, tool_call_chunks_ in tool_call_chunks.items(): | |||
| for tool_call_index, (_tool_call_id, tool_call_chunks_) in enumerate(tool_call_chunks.items()): | |||
Parker-Stafford
commented
Oct 25, 2024
| [ToolAttributePostfixes.json_schema]: toolJSONSchemaSchema, | ||
| }), | ||
| }) | ||
| .optional() |
There was a problem hiding this comment.
made everything optional here and filtered before passing to the playground so we can capture some tools even if some are malformed
cephalization
approved these changes
Oct 28, 2024
Parker-Stafford
force-pushed
the
parker/span-tools-to-playground
branch
from
9476b02
to
cc33a55
Compare
dosubot
bot
added
size:XXL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools on span to playground
Screen.Recording.2024-10-25.at.4.07.54.PM.mov
scrollable input / output
made the whole pane scrollable so we didn't have to make each accordion item scroll which would make us need to enforce a max height on each, causing one to shrink when the other grows
Screen.Recording.2024-10-25.at.10.27.58.AM.mov
Resulting ui error from tool attributes bug
attributes