Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: px.Client().get_dataset_versions should use self._client.get instead of httpx.get #5220

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

RogerHYang
Copy link
Contributor

No description provided.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 29, 2024
@RogerHYang RogerHYang changed the title fix: replace httpx.get with self._client.get fix: replace httpx.get with self._client.get in px.Client().get_dataset_versions Oct 29, 2024
@RogerHYang RogerHYang changed the title fix: replace httpx.get with self._client.get in px.Client().get_dataset_versions fix: should use self._client.get in px.Client().get_dataset_versions Oct 29, 2024
@RogerHYang RogerHYang changed the title fix: should use self._client.get in px.Client().get_dataset_versions fix: px.Client().get_dataset_versions should use self._client.get instead of httpx.get Oct 29, 2024
@RogerHYang RogerHYang merged commit c810e16 into main Oct 29, 2024
37 checks passed
@RogerHYang RogerHYang deleted the fix- branch October 29, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants