Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The console wasn't using its own UI theme #169

Closed
CoderJo-Pro opened this issue Apr 5, 2024 · 3 comments
Closed

The console wasn't using its own UI theme #169

CoderJo-Pro opened this issue Apr 5, 2024 · 3 comments

Comments

@CoderJo-Pro
Copy link

Describe the bug
As the title says. I seek through panku console's folder, and I saw there's a theme and a font resource, but never used. Because I'm using my own theme resource, and this theme's font is a pixel font. (my project's font is set by theme instead of the project settings)
It font referencing is weird. some is my pixel font, and some is its own modern font.

To Reproduce
Steps to reproduce the behavior:

  1. Create a theme resource
  2. Set it to ProjectSettings:gui/theme/custom
  3. Override Label style (change some for example font color and font size) of the theme
  4. Run whatever scene you have
  5. Open the panku console and you'll see the console is somewhat strange

Expected behavior
it just uses its own theme resource, and user's (me) original project changes won't effect its appearance.

Screenshots
Snipaste_2024-04-05_15-51-58
this project had been upload on itch.io

@Ark2000
Copy link
Owner

Ark2000 commented Apr 6, 2024

Well, currently fonts resources are scattered around different scenes.

For now, if you want to change the output fonts:

  1. go to panku_console_ui.tscn
  2. find the node RichTextLabel
  3. change its fonts theme overrides, done.

image

image

Thanks for your feedback, I will work on UI issues later to make it more unified and customizable.

@CoderJo-Pro
Copy link
Author

well I think you can just make your root window control node to use the console's theme.
this will make the children inherits the theme from window root, no origin project changes will effect panku console.

this is my simple thought for improvement :P

@Ark2000
Copy link
Owner

Ark2000 commented May 5, 2024

Closed. Related issue: #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants