/api/transactions/search to handle search by recipient from multipayment recipients

[air1one]

POST /api/transactions/search currently doesn't support to search multipayment tx by recipients since the recipients sit in the asset of the multipayment transaction.

[rainydio]

Okay. But as an alternative I can also enable OR condition for search endpoints, so that multipayment can be included like this:

[
  { "recipientId": "<recipient address>" },
  { "asset": { "payment": { "recipientId": "<recipient address>"  } } }
]

Or I can add additional aggregated criteria property:

{ "anyRecipientId": "<recipient address>" }

Otherwise it isn't clear why transactions that are included into result may have unexpected recipientId that doesn't match specified criteria (because asset.payment.recipientId does).

[air1one]

Yeah OR could be good, what do you think @faustbrian ?

[faustbrian]

Not really a fan of that because we don't require special recipient types to be specified for anything else and that just makes it more tedious to retrieve transactions.

When you request transactions via API without a type or typeGroup filter your expectation would be that you get all transactions that could have a recipientId without thinking about what type the transaction is.

Also, this has to work with the addresses parameter which can be used to look up transactions for multiple addresses at the same time.

[rainydio]

Not gonna fight for it, that rule was already broken for delegate registration.

[faustbrian]

There is no rule that was broken. There are special transaction types that are sent to yourself because they need to go somewhere but a multi-payment is just a transfer (type 0) that has multiple recipients.

[rainydio]

• recipientId now searches through multipayment too
• added address criteria to filter by either recipientId or senderId