Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ui5-test-runner opens browser windows for tests with puppeteer >= 23.2.0 #100

Open
heimwege opened this issue Sep 12, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@heimwege
Copy link

Describe the bug
I increased the version of puppeteer: 22.13.1 -> 23.3.0
When running the tests on my local machine a blank (browser?) window shows up.

image
(this is an actual screenshot 😸 )

Tested with ui5-test-runner 5.3.1 and 5.3.3. Used run command

"ui:test:server": "ui5 serve --config ./ui5-test.yaml",
"ui:test:runner": "ui5-test-runner --port 8081 --url http://localhost:8080/test/testsuite.qunit.html --report-generator $/report.js $/junit-xml-report.js --report-dir ./target/QunitReport --coverage true --fail-opa-fast --split-opa --coverage-settings ./.nycrc.json",
"ui:test": "start-server-and-test ui:test:server http://localhost:8080/ ui:test:runner",

As soon as I downgrade puppeteer to 23.1.1 everything is back to normal. Issue seems to come from puppeteer >= 23.2.0

Expected behavior
No extra window showing up when executing the tests.

Report
Issue not related to any test result

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome

Additional context
None

@heimwege heimwege added the bug Something isn't working label Sep 12, 2024
@ArnaudBuchholz
Copy link
Owner

Thanks for the submission... I also observed that behavior. Yet, it does not fail the tests. I will check on puppeteer repo to see if they are aware of the issue.

@ArnaudBuchholz
Copy link
Owner

Tested again with puppeteer@23.4.1, problem still present

@ArnaudBuchholz
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants