Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decouple tests in taskmodules/test_transformer_re_text_classification #110

Open
ArneBinder opened this issue Mar 7, 2022 · 0 comments
Open

decouple tests in taskmodules/test_transformer_re_text_classification #110

ArneBinder opened this issue Mar 7, 2022 · 0 comments
Labels
testing Testing

Comments

@ArneBinder
Copy link
Owner

ArneBinder commented Mar 7, 2022 •
edited
Loading

To ease test transparency and future changes of individual parts of the taskmodule,

  • encode_target should not be tested by calling encode with encode_target=True, but just calling the method
  • in test_decode, encode should not be called to get encodings

This will require the following fixture:

  • encoded_inputs_metadata_documents for test_encode_target, and
  • encodings for test_decode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ArneBinder