Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing Audio in VOD's #37

Open
MacClelland opened this issue Aug 25, 2018 · 1 comment
Open

[Bug] Missing Audio in VOD's #37

MacClelland opened this issue Aug 25, 2018 · 1 comment

Comments

@MacClelland
Copy link

When you Download a Full VOD or a VOD time frame. If the first chunk of either the section or the Full VOD is muted by Twitch because of copyright the entire VOD stays muted. Even if the audio is back at some point in the vod the download has still no audio.

When you start a Download 1 minute after the muted part audio is there and even after at a later time the audio is muted by Twitch it is muted in the download too but the audio resumes after the muted part.

It only occurs if the VOD starts muted by Twitch. The download must have had audio before. If its muted right at the beginning the whole Vod stays muted. If it had audio before it works like in the twitch player.

@jtguibas
Copy link

jtguibas commented Mar 3, 2019

For anyone who is troubled on how to solve this, the problem is that ffmpeg concatenation fails to build an audio stream when the first .ts chunk does not have audio. To solve this, I simply wrote a small if statement to replace the first chunk with a chunk I know has audio. Another solution could be to simply have a blank .ts that has an audio stream. Here's my hacky solution:

On line 218
s := strconv.Itoa(i) if i == 0 { fmt.Println("Activated on zero.") s = strconv.Itoa(120) } else { s = strconv.Itoa(i) }

Note: I'm having problems playing back the chunks with no audio, but it looks like the rest of the video works now. Worth looking more in to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants