Skip to content

Commit c11ee52

Browse files
authored
fix chart linting (newrelic#731)
1 parent 26e2fb8 commit c11ee52

File tree

3 files changed

+26
-3
lines changed

3 files changed

+26
-3
lines changed

.github/ct-install.yaml

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# In this repository there are two folder with charts that need to be released. One can think that it would be easier to simply at to this file
2+
# a chart-dirs clause pointing to both of the folders at the same time:
3+
4+
# ```yaml
5+
# chart-dirs:
6+
# - library
7+
# - charts
8+
# ```
9+
10+
# In that case `ct install` is going to try to install the library chart and is going to fail. That is the reason there are two `ct.yaml` files, one
11+
# for the step that lint that includes all the folders at the same time and other of the installation step that test installability
12+
13+
chart-dirs:
14+
# - library # I leave this commented for clarity's sake
15+
- charts
16+
17+
chart-repos:
18+
- kube-state-metrics=https://kubernetes.github.io/kube-state-metrics
19+
- pixie-operator=https://pixie-operator-charts.storage.googleapis.com

.github/ct-lint.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,7 @@
1313
chart-dirs:
1414
- library
1515
- charts
16+
17+
chart-repos:
18+
- kube-state-metrics=https://kubernetes.github.io/kube-state-metrics
19+
- pixie-operator=https://pixie-operator-charts.storage.googleapis.com

.github/workflows/lint_test_charts.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
- name: Check for changed installable charts
5151
id: list-changed
5252
run: |
53-
changed=$(ct list-changed)
53+
changed=$(ct list-changed --config .github/ct-install.yaml)
5454
if [[ -n "$changed" ]]; then
5555
echo "::set-output name=changed::true"
5656
fi
@@ -63,6 +63,6 @@ jobs:
6363
run: kubectl create ns ct
6464

6565
- name: Test install charts
66-
run: ct install --namespace ct
66+
run: ct install --namespace ct --config .github/ct-install.yaml
6767
- name: Test upgrade charts
68-
run: ct install --namespace ct --upgrade
68+
run: ct install --namespace ct --config .github/ct-install.yaml --upgrade

0 commit comments

Comments
 (0)