Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check for hardware float support #8

Open
Am0g-us opened this issue Oct 26, 2024 · 2 comments
Open

Properly check for hardware float support #8

Am0g-us opened this issue Oct 26, 2024 · 2 comments

Comments

@Am0g-us
Copy link

Am0g-us commented Oct 26, 2024


cargo run --release
Finished release profile [optimized] target(s) in 0.79s
Running target/release/brush_bin
"sparse/0/cameras.bin" "sparse/0/images.bin"
[2024-10-26T16:15:28Z ERROR wgpu_core::device::global] Device::create_shader_module error:
Shader validation error:

[2024-10-26T16:15:28Z ERROR wgpu::backend::wgpu_core] Handling wgpu errors as fatal by default
thread 'async-std/runtime' panicked at /home/amongus/.cargo/git/checkouts/wgpu-f9afa33caa1e84c9/ffb4852/wgpu/src/backend/wgpu_core.rs:3411:5:
wgpu error: Validation Error

Caused by:
In Device::create_shader_module

Shader validation error:

  Type [12] '' is invalid
    Capability Capabilities(SHADER_FLT32_ATOMIC) is required

note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
"sparse/0/cameras.bin" "sparse/0/images.bin"
[2024-10-26T16:15:52Z ERROR wgpu_core::device::global] Device::create_shader_module error:
Shader validation error:

[2024-10-26T16:15:52Z ERROR wgpu::backend::wgpu_core] Handling wgpu errors as fatal by default
thread 'async-std/runtime' panicked at /home/amongus/.cargo/git/checkouts/wgpu-f9afa33caa1e84c9/ffb4852/wgpu/src/backend/wgpu_core.rs:3411:5:
wgpu error: Validation Error

Caused by:
In Device::create_shader_module

Shader validation error:

  Type [12] '' is invalid
    Capability Capabilities(SHADER_FLT32_ATOMIC) is required

My gpu is amd 6900 xt. Installed latest rocm and mesa drivers.

@ArthurBrussee
Copy link
Owner

Ah yes - I think that's the same as #6!

I've disabled hardware atomic floats for now, but should re-enable them soon with proper detection whether they are supported! Will leave this issue open until that's done.

@AsherJingkongChen
Copy link

AsherJingkongChen commented Oct 28, 2024

I guess that it hardly works on AMD GPUs.
The Vulkan extension was originally contributed by NVIDIA's developers.

Accessibility issues of float atomic operations can be solved by atomic CAS loop on integer types. This can be handled in wgpu internals or by checking WgpuDeivce enabled features in runtime.

See gfx-rs/wgpu#6234

@ArthurBrussee ArthurBrussee changed the title Linux error Properly check for hardware float support Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants