Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some classes show the wrong assignments when switching terms #113

Closed
psvenk opened this issue Mar 24, 2020 · 1 comment · Fixed by #220
Closed

Some classes show the wrong assignments when switching terms #113

psvenk opened this issue Mar 24, 2020 · 1 comment · Fixed by #220
Assignees
@psvenk
Labels
backend Suspected problem with backend (server or scraper) bug Something isn't working
Milestone
2.7.0

Comments

@psvenk
Copy link
Member

psvenk commented Mar 24, 2020

When I switch from "Current Quarter" (Q3) to Q2, one of my classes shows assignments from the second page of Q2 assignments and the second page of Q3 assignments, instead of showing the first and second page of Q2 assignments. I suspect that this is because Aspen "remembers" that it is on the second page (as it needed to scrape the second page of the "current" quarter after the first page) and gives the second page of Q3 assignments. Aspine's scraper also switches terms instead of trying to go to the next page for some reason or fills in "current quarter" data because it does not see any second page.

I am guessing that this bug can be fixed by having the scraper go back to the first page once done with scraping a class for some quarter.
@psvenk psvenk added the bug Something isn't working label Mar 24, 2020
@notrodes notrodes added the backend Suspected problem with backend (server or scraper) label Mar 27, 2020
@notrodes notrodes reopened this Mar 27, 2020
@notrodes
Copy link
Collaborator

Sorry pressed wrong button

@psvenk psvenk mentioned this issue Nov 25, 2020
Closed
@psvenk psvenk modified the milestones: 2.6.0, 2.5.2 Nov 29, 2020
@psvenk psvenk mentioned this issue Dec 19, 2020
Merged
7 tasks
@psvenk psvenk linked a pull request Dec 19, 2020 that will close this issue
Migrate to REST API #220
Merged
7 tasks
@psvenk psvenk modified the milestones: 2.8.0, 2.7.0 Dec 24, 2020
@psvenk psvenk self-assigned this Jan 6, 2021
@psvenk psvenk modified the milestones: 2.6.2, 2.7.0 Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psvenk psvenk

Labels
backend Suspected problem with backend (server or scraper) bug Something isn't working
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

Migrate to REST API Aspine/aspine
2 participants
@psvenk @notrodes